Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual textsmoothing? #63

Closed
johnhenrypezzuto opened this issue Jan 19, 2022 · 4 comments
Closed

Manual textsmoothing? #63

johnhenrypezzuto opened this issue Jan 19, 2022 · 4 comments

Comments

@johnhenrypezzuto
Copy link

Hi all,

Thanks for the fantastic package. I'm not sure if this is planning on being implemented but I think some kind of scale_textsmooth_manual or a vector of textsmooth inputs would be useful idea to keep in mind. It's been an issue that has been coming up for me while I've been using the package. Thank you so much!

@AllanCameron
Copy link
Owner

Hi John. Thanks for adding this issue. At the moment text smoothing is a single - valued parameter and not an aesthetic. I don't think it makes sense to have it as an aesthetic mapping, but vectorised input might be possible. We had not considered this - are you able to provide a motivating example to show where this might be helpful? It would probably require quite a lot of development to allow per-string smoothing, so it would be good to see where it might be useful.

@teunbrand
Copy link
Collaborator

I agree with Alan here that an evident benefit would be very nice to see. I personally see the text smoothing as a last resort: something you'd use when there are no other methods available anymore. Two scenarios in which that can happen if when you're using a stat that still returns a noisy path, in which case you cannot use geom_(text)smooth() or when you're using geom_textsf() and it is simply harder to tweak the underlying data. In a worst case scenario, you could still split up the data per path and add individual layers, each with their own text smoothing.

@AllanCameron
Copy link
Owner

I agree Teun - there will always be work-arounds. It might be that there are frequent use cases where it makes sense, but I can't think of them. I'm quite fond of using the text-smoothing rather than seeing it as a last resort - I think many of the community examples I see would benefit from a little bit of text smoothing, but in any case I would definitely want to see a motivating example here.

@AllanCameron
Copy link
Owner

This has been open a while, and no motivating example appears to be forthcoming. Happy to reconsider it later if someone wants to show us where it would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants