Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggplot2 is separating size and linewidth #80

Closed
teunbrand opened this issue Jun 20, 2022 · 2 comments
Closed

ggplot2 is separating size and linewidth #80

teunbrand opened this issue Jun 20, 2022 · 2 comments

Comments

@teunbrand
Copy link
Collaborator

Hey Allan,

The ggplot2 have separated the size and linewidth aesthetics.
Thomas has posted guidelines on twitter of potential steps extension developers might take to do the same.
While we already use the linewidth aesthetic almost anywhere, to not conflate the text's size, do you think we need to take any action? I'm not too familiar with the geom_text_sf() internal workings, but it'd be good to hear if you think it may need to be changed.

Best,
Teun

@AllanCameron
Copy link
Owner

Hi Teun.

The geom_textsf has separate size and linewidth aesthetics, and I'm pretty sure all the other geoms do too, so I don't think we need to take any specific action here. I guess we could build and test with the dev version of ggplot2, but I think we can safely postpone until the next release.

Regards

Allan

@teunbrand
Copy link
Collaborator Author

Yes good points, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants