Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building with useFrameworks: "static" for iOS devices #11

Closed
MarchewkaMatthew opened this issue May 23, 2023 · 4 comments
Closed

Comments

@MarchewkaMatthew
Copy link

Hi @andrejpavlovic !

Thank you for maintaining this module. I have a question regarding building this plugin with useFrameworks: "static" set for iOS devices (added with the expo-build-properties). I need to add it in order to enable React Native Firebase in my project. I'm not really sure what that would require from the package to support building from the "framework" instead of the static library.

app.config.ts:

      [
        "expo-build-properties",
        {
          ios: {
            useFrameworks: "static",
          },
        },
      ],

Error message during run fastlane step in the eas build:

image

Thank you in advance for your help!

@andrejpavlovic
Copy link
Contributor

Isn't that error related to this issue?
#6

@MarchewkaMatthew
Copy link
Author

Hi @andrejpavlovic, I'm not sure. in the eas build steps expo prebuild seems to work just fine. I also have expo-notifications added to my plugins list. I will try to add s.dependency 'EXNotifications' and let you know about the result.

@MarchewkaMatthew
Copy link
Author

It indeed fixed the issue 👍 I've updated my PR to this repository: #9

@andrejpavlovic
Copy link
Contributor

Published fix in 48.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants