USE_TZ = True.

[fossilet]

We are using the following settings regarding timezone:

TIME_ZONE = 'Europe/Warsaw'
USE_TZ = False

When USE_TZ is False, Django would store timestamps in the timezone of TIME_ZONE, and this is how ralph is storing time. After I realised I should change TIME_ZONE, even if I changed TIME_ZONE to 'Asia/Beijing', the stored time are still in the old timezone (GMT+1). How about it that we change USE_TZ to True, to make sue time is always saved as UTC? This is also recommended by Django.

[mkurek]

Hi @fossilet. We cannot simply enable USE_TZ right now because it breaks existing code. Take a look at travis unit tests - some of them are broken. Its probably caused by using datetime core module of Python instead of django.utils.timezone (https://docs.djangoproject.com/es/1.9/topics/i18n/timezones/#naive-and-aware-datetime-objects) - will you be able to fix these broken places in our code?

[fossilet]

Oops, let me see.

[fossilet]

The difference of the objects in the failed test is two hours. I cannot find why. @mkurek can you have a look at it?

[ghost]

@fossilet it looks like openstack importer has issue which blocks this pull request.
I'm gonna fix that and we handle your case, ok?

[fossilet]

@xliiv great.

[ghost]

The bug which I mentioned earlier is because timezone is skipped here:
https://github.com/allegro/ralph/blob/ng/src/ralph/virtual/management/commands/openstack_sync.py#L309
It turned out also that it'd be easier when you merge my changes (then the opposite)
So here's the changes:
ng...xliiv:open-stack-tz
A few tests are broken in my change but I think you already fixed them.
If not give some feedback.

[fossilet]

@xliiv, there is still a flake error even if I have fixed one.

[ar4s]

@fossilet remove this line https://github.com/allegro/ralph/pull/2263/files#diff-4fa30bd6416c1bceb147b0bf9dbf6999R5

[fossilet]

@ar4s, I saw the error, but it is in fact used by the newly added code by @xliiv. That's why I asked him to have a look. Maybe its an error of flake8 itself.

[mkurek]

@fossilet no it's not used - he replaced datetime.strptime by parser.parse.

[fossilet]

I have fixed it.

[mkurek]

self.DATETIME_FORMAT is not used anymore - could you delete it in line 49?

[fossilet]

@mkurek I've added it.

[mkurek]

@fossilet thanks. we'll pull and test your code if it works well with our current setup.

[mkurek]

Continued in #2391