Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLEARML_FILES_HOST=undefined when create new credentials for Jupyter Notebook #67

Closed
amishurov opened this issue Feb 16, 2024 · 6 comments

Comments

@amishurov
Copy link

Hello, I'm using self-hosted ClearML CLEARML_SERVER_VERSION=1.14.0, deployed via docker-compose
When create new credentials for notebook get this autogenerated config

%env CLEARML_WEB_HOST=https://my.domain
%env CLEARML_API_HOST=https://my.domain:8008
%env CLEARML_FILES_HOST=undefined
%env CLEARML_API_ACCESS_KEY=XXX
%env CLEARML_API_SECRET_KEY=YYY

config for local python looks like:

api { 
    web_server: https://my.domain
    api_server: https://my.domain
    credentials {
        "access_key" = "xxx"
        "secret_key"  = "yyy"
    }
}

How could I fix this behavior? Thank you

@shyallegro
Copy link
Contributor

@amishurov do you mean in the code or your configuration?

@amishurov
Copy link
Author

@shyallegro, will be cool, if this could be fixed via setting additional configuration, or any other way to set fileserver url explicitly.
Took quick look at source code, and I supposed my problem is that my base url (window.location.origin) without port 8080

} else if (window.location.port === '8080') {

@shyallegro
Copy link
Contributor

either that, or add/mount a configuration.json file to nginx root specifying fileBaseUrl
I'll make sure a fix is added to 1.15 that hides fileserver if it's not defined

@amishurov
Copy link
Author

Added volume to clearml-webserver according to wrapper.sh:

volumes:
- /opt/clearml/webserver/configuration.json:/mnt/external_files/configs/configuration.json

configuration.json in the right place and not empty

$ docker exec -it clearml-webserver cat /usr/share/nginx/html/configuration.json
{
  "fileBaseUrl": "https://my.domain:8081"
}

but still get in WebUI

%env CLEARML_FILES_HOST=undefined

@shyallegro could you help, please?

@shyallegro
Copy link
Contributor

can you try this config in configuration.json

{
  "displayedServerUrls": {
    "apiServer": "https://my.domain:8008",
    "filesServer": "https://my.domain:8081"
  }
}

@amishurov
Copy link
Author

Works fine, thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants