Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/Enhancement: Slow dataset verification #1130

Closed
charlienewey-odin opened this issue Oct 6, 2023 · 0 comments · Fixed by #1131
Closed

Bug/Enhancement: Slow dataset verification #1130

charlienewey-odin opened this issue Oct 6, 2023 · 0 comments · Fixed by #1131
Labels
bug Something isn't working

Comments

@charlienewey-odin
Copy link
Contributor

Describe the bug

Dataset verification is slow when verifying lots of small files. This is especially true on e.g. NFS drives.

To reproduce

Download a dataset, then download it again.

from clearml import Dataset

d = Dataset.get(dataset_id="abcdefg")

# Populate cache, verification happens here and is slow
d.get_local_copy()

# Verification on a pre-downloaded/cached dataset is also slow
d.get_local_copy()

Expected behaviour

Verification (i.e. file size checking) can theoretically happen in parallel on certain disk types - especially NFS drives that have multiple copies of stored data (e.g. Ceph, GlusterFS, or in my case, GCP Filestore).

Environment

  • SDK version: 1.13.1
  • ClearML Server Version: Enterprise
  • OS/Python not relevant

Related Discussion

Slack thread: https://odin-vision.slack.com/archives/C055MNE258R/p1696591022780369

@charlienewey-odin charlienewey-odin added the bug Something isn't working label Oct 6, 2023
@charlienewey-odin charlienewey-odin changed the title Slow dataset verification Bug/Enhancement: Slow dataset verification Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant