Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with submodule updates #112

Closed
tomeramit opened this issue Mar 8, 2020 · 5 comments
Closed

problem with submodule updates #112

tomeramit opened this issue Mar 8, 2020 · 5 comments

Comments

@tomeramit
Copy link

Hi,
I am using a submodule inside my code, on the father repo I committed the change when moving the child repository, and when I check the venvs-builds package git status, I see that the pointer to the submodule is modified (in my repo on my local pc it is not modified, and is is commited to the git)

when I do git submodule update it fix the problem, but when I launch experiment it goes back again.

how can I solve this? what I do wrong?

@bmartinn
Copy link
Member

bmartinn commented Mar 9, 2020

Hi @tomeramit ,

  1. What version of trains-agent are you using?
    I think there was a fix in 0.13.2 that might have something to do with sub-modules
  2. If you do a clean git clone --recursive , will you get the correct version of the submodules ?
  3. If you are unsure of the specific commit ID in the main repository, you can edit the experiment and instead of specific commit, you can select the latest in the master branch

@tomeramit
Copy link
Author

tomeramit commented Mar 9, 2020

  1. I'm using train-agent version 0.13.2
  2. when I do "git clone -b branch_name repo_name --recursive" it's working correctly

If I do "git submodule update" on the repo inside the venvs-builds it fixes the problem, but when I launch the experiment it goes back into the wrong submodule commit state

@bmartinn
Copy link
Member

bmartinn commented Mar 9, 2020

@tomeramit did you try option (3) ?

Also, are you getting the correct repository and sub-repo if you do:

git clone <repo_name> --recursive
git fetch --all --recurse-submodules
git checkout <Specific commit id as seen on the experiment Execution section>

And if you do not, does that help?

git submodule update --recursive

@bmartinn
Copy link
Member

Hi @tomeramit,

Please try out the following Trains Agent fix version and let me know if it solves your issue:
$ pip install trains-agent==0.14.0rc0

@tomeramit
Copy link
Author

now its working!
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants