parse queue name #857
Merged
parse queue name #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! Really useful feature! |
jkhenning
reviewed
Dec 28, 2022
clearml/automation/controller.py
Outdated
| return node.job.launch(queue_name=node.queue or self._default_execution_queue) | ||
|
|
||
| parsed_queue_name = self._parse_step_ref(node.queue) | ||
| return node.job.launch(parsed_queue_name or self._default_execution_queue) |
There was a problem hiding this comment.
@Anton-Cherepkov just like in the previous diff, I think it would be better to keep the previous keyword calling style (i.e. queue_name=...)
There was a problem hiding this comment.
@Anton-Cherepkov can you please change this to:
return node.job.launch(queue_name=parsed_queue_name or self._default_execution_queue)
There was a problem hiding this comment.
@jkhenning yes, sure. 04165b7
keyword queue_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue \ discussion
https://clearml.slack.com/archives/CTK20V944/p1671538941447289
Patch Description
Now one may specify things like
${pipeline.queue_name}forqueue_nameand control the execution queue of each task via pipeline parameters.Testing Instructions
Other Information