Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UniformParameterRange tolist throws when no step size defined #858

Open
davyx8 opened this issue Dec 25, 2022 · 3 comments
Open

UniformParameterRange tolist throws when no step size defined #858

davyx8 opened this issue Dec 25, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@davyx8
Copy link
Contributor

davyx8 commented Dec 25, 2022 •
edited

Describe the bug

A clear and concise description of what the bug is.
when creating unifromrangeparam with no step size, list throws exception, the fix is obvious:
image

To reproduce

Exact steps to reproduce the bug. Provide example code if possible.
image

Expected behaviour

return a proper list

Environment

all envs all versions

Related Discussion
@davyx8 davyx8 added the bug Something isn't working label Dec 25, 2022
@ainoam
Copy link
Collaborator

ainoam commented Dec 26, 2022

Thanks for catching this @davyx8!

Care to do the honors with a PR?

This was referenced Dec 26, 2022
Merged
Merged
@davyx8
Copy link
Contributor Author

davyx8 commented Dec 26, 2022

done https://github.com/allegroai/clearml/pull/859

@pollfly
Copy link
Contributor

pollfly commented Jan 25, 2023

Hey @davyx8! Just letting you know that this issue has been resolved in the recently released v1.9.1. Let us know if there are any issues :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davyx8 @ainoam @pollfly