-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links do not have a discernible name #29
Comments
Accessibility is tough to solve in a generic fashion for a project such as this; there are a lot of things that can be opinionated or have different requirements. This is why this project doesn't force any practices onto its users. That being said, making links accessible is already possible by using the Take for example, this unit test which is using Bootstrap's jekyll-anchor-headings/_tests/customAnchorBody.html Lines 9 to 21 in 27ca069
But if you don't want to use a CSS class like that, you could also use But wait, what if you want to use So, the ability to make the links discernible already exists in this project. It just happens to be opt-in because there are so many different ways of handling this. |
I could, however, create a page in this project's wiki describing the different ways of handling links in an accessible manner. How does that sound? |
This sounds fantastic. I actually prefer to set the |
@askel45 here you go! https://github.com/allejo/jekyll-anchor-headings/wiki/Link-Accessibility#hiding-links-entirely-for-screen-readers |
I am getting this accessibility error "Links do not have a discernible name" for all links created from headings (you can try testing a post from your test site using web.dev). Would you consider correcting it to address the issue? https://web.dev/link-name/?utm_source=lighthouse&utm_medium=lr
The text was updated successfully, but these errors were encountered: