Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design review #16

Closed
16 of 19 tasks
meganrm opened this issue Mar 6, 2024 · 6 comments · Fixed by #24
Closed
16 of 19 tasks

Design review #16

meganrm opened this issue Mar 6, 2024 · 6 comments · Fixed by #24

Comments

@meganrm
Copy link
Collaborator

meganrm commented Mar 6, 2024

@meganrm
Copy link
Collaborator Author

meganrm commented Mar 11, 2024

@TravisKroeker when this PR finishes building there will be a link to see a working preview

@meganrm
Copy link
Collaborator Author

meganrm commented Mar 13, 2024

@TravisKroeker most recent version, which should include all the changes that I've checked off on this issue

@TravisKroeker
Copy link

@meganrm These changes look great! A couple notes on the parental line modals:

  • "More Info" button text still looks tiny. Bump it up to 16pt and semibold it.
  • The changes to the font size in the body of the modal (which look much better) are causing it to wrap. Let's bump up the width of the modal slightly so that it's on a single line. Eventually we might have some gene names that are extraordinarily long and will need to wrap, but not for a couple years if ever.

I might have a few more comments once the obtain cell line and cert. of analysis features are put in place but the rest is soooooo clean.

@meganrm
Copy link
Collaborator Author

meganrm commented Mar 13, 2024

@meganrm These changes look great! A couple notes on the parental line modals:

  • "More Info" button text still looks tiny. Bump it up to 16pt and semibold it.
  • The changes to the font size in the body of the modal (which look much better) are causing it to wrap. Let's bump up the width of the modal slightly so that it's on a single line. Eventually we might have some gene names that are extraordinarily long and will need to wrap, but not for a couple years if ever.

I might have a few more comments once the obtain cell line and cert. of analysis features are put in place but the rest is soooooo clean.

  • "More Info" button text still looks tiny. Bump it up to 16pt and semibold it.
  • The changes to the font size in the body of the modal (which look much better) are causing it to wrap. Let's bump up the width of the modal slightly so that it's on a single line. Eventually we might have some gene names that are extraordinarily long and will need to wrap, but not for a couple years if ever.

@meganrm
Copy link
Collaborator Author

meganrm commented Mar 14, 2024

@TravisKroeker this link has been updated with the two additional tweaks on the parental line modal

@TravisKroeker
Copy link

Love it. Noticed you made changes to the icon hover state too to match the text. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants