-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecordingControls should use TimeControls #30
Comments
also to consider: |
Echoing a comment from Cameron, this ticket is also a good opportunity to pull out the code that gets DOM controls and binds handlers, and put it back into main, so that TimeControls and RecordingControls just contain the handlers themselves. In which case I would change the class names to Controller instead of Controls. Similar in spirit to the above comment. |
Can we use just one timeout? (timeout instead of setInterval?) |
Use Case
Internal-only, non-user affecting. Reduce code complexity by having TimeControls and RecordingControls' advancement loops use the same underlying logic, just with separate callback behavior.
Acceptance Criteria
Details
e.g.:
private playTimeSeries(onNewFrameCallback: () => void, onCompleted: () => void, intervalMs: number): void {}
The text was updated successfully, but these errors were encountered: