Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encapsulate the feature color ramp controls in a module #32

Closed
Tracked by #52
toloudis opened this issue Jun 22, 2023 · 0 comments · Fixed by #111
Closed
Tracked by #52

encapsulate the feature color ramp controls in a module #32

toloudis opened this issue Jun 22, 2023 · 0 comments · Fixed by #111
Labels
internals Tech debt, refactoring, dependencies, etc.

Comments

@toloudis
Copy link
Contributor

Use Case

Just to clean up the code a bit, we can encapsulate all the controls around locking min/max, reset, and setting min/max into a separate file.

Acceptance Criteria

main.ts gets smaller and simpler and forwards calls into some kind of Feature or FeatureController class.

Details

Does this really help anything?
@toloudis toloudis added the internals Tech debt, refactoring, dependencies, etc. label Jun 22, 2023
@toloudis toloudis mentioned this issue Aug 8, 2023
Closed
11 tasks
@ShrimpCryptid ShrimpCryptid mentioned this issue Aug 24, 2023
Merged
5 tasks
This was referenced Oct 9, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internals Tech debt, refactoring, dependencies, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Cleanup Internals allen-cell-animated/timelapse-colorizer
1 participant
@toloudis