Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ColorizeCanvas into a react component #76

Closed
Tracked by #52
ShrimpCryptid opened this issue Aug 30, 2023 · 0 comments · Fixed by #111
Closed
Tracked by #52

Refactor ColorizeCanvas into a react component #76

ShrimpCryptid opened this issue Aug 30, 2023 · 0 comments · Fixed by #111
Labels
internals Tech debt, refactoring, dependencies, etc.

Comments

@ShrimpCryptid
Copy link
Contributor

Acceptance Criteria

  • ColorizeCanvas should be invoked from App like a component (e.g., current setters are replaced with props that are updated as part of React's render cycle).
<ColorizeCanvas
   dataset={...}
   featureName={...}
   selectedTrack={...}
   ramp={...}
   rampMin={...}
   rampMax={...}
   ...
/>
  • Internally, ColorizeCanvas can still break the React render paradigm and update its HTMLCanvas separately.

Details

  • Unsure if this will break things like timeControls/recordingControls loops?
@ShrimpCryptid ShrimpCryptid added the internals Tech debt, refactoring, dependencies, etc. label Aug 30, 2023
@toloudis toloudis mentioned this issue Aug 30, 2023
11 tasks
@ShrimpCryptid ShrimpCryptid linked a pull request Oct 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Tech debt, refactoring, dependencies, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant