Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation feature is not included? #26

Closed
orifn opened this issue Mar 8, 2017 · 4 comments
Closed

Rotation feature is not included? #26

orifn opened this issue Mar 8, 2017 · 4 comments

Comments

@orifn
Copy link
Collaborator

orifn commented Mar 8, 2017

Hi there,
we are currently using latest commit which is still missing image rotation functionality. The topic is actually discussed here. So, are you planing to include it?
Would be great to have it soon :)

@allenJynRoyston
Copy link
Owner

Hey, sorry I haven't really been maintaining this module as well as I should have. I have a full time job and side projects I'm working on and this one kind of fell to the wayside. Apologies in advance, but I probably won't get around to updating this any time soon :(

@orifn
Copy link
Collaborator Author

orifn commented Mar 9, 2017

I actually added some changes to your code and it works great with rotation functionality!
So, if you include me to the list of contributors (or maybe as co-authors :D just kidding) I would be happy to share those changes. This could lead us to first official release version of ngCroppie ;)

@allenJynRoyston
Copy link
Owner

Hey orif-jr, sorry I didn't get around to this sooner. (Ugh work). If you have a pull-request you'd like to submit, I'll happily merge it in and add you to the list of credits. Sorry again about the delay.

@orifn
Copy link
Collaborator Author

orifn commented Mar 24, 2017

Great!
Just created a new pull request, which contains code changes/ enhancement and updated readme file.
Btw, it makes sence to release first official version now, because until now ngCroppie is available only with commit hashes (and it's disaster). I can do that also as soon as you give me access to the repo. This way I could contribute better and things could go faster ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants