Be more explicit about use_cache to avoid #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyf
commented
Sep 7, 2021
| python scripts/transfer_experiment_seed_paper.py --n_jobs 25 --random_seed 1 2 3 4 5 --skip_individual_models --experiment_name paper_experiments/ablations/no_affiliation --feature_groups_to_skip affiliation_similarity --use_cache | ||
| python scripts/transfer_experiment_seed_paper.py --n_jobs 25 --random_seed 1 2 3 4 5 --skip_individual_models --experiment_name paper_experiments/ablations/no_year --feature_groups_to_skip year_diff --use_cache | ||
| python scripts/transfer_experiment_seed_paper.py --n_jobs 25 --random_seed 1 2 3 4 5 --skip_individual_models --experiment_name paper_experiments/ablations/no_coauthors --feature_groups_to_skip coauthor_similarity --use_cache | ||
| python scripts/transfer_experiment_seed_paper.py --n_jobs 25 --random_seed 1 2 3 4 5 --skip_individual_models --experiment_name paper_experiments/ablations/no_references --feature_groups_to_skip reference_features --use_cache | ||
|
|
||
| # SOTA | ||
| python scripts/sota.py --n_jobs 25 --random_seed 42 --inspire_split 0 --inspire_only --experiment_name paper_experiments_sota/inspire_split_0/ |
There was a problem hiding this comment.
The SOTA scripts don't have a cache flag. It was hardcoded to True.
dakinggg
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zhipeng and the SPECTER+ team missed the cache specification and were debugging for a long time. These changes should hopefully make the cache easier to understand and notice.