Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fix file friendly logging #3785

Closed
brendan-ai2 opened this issue Feb 14, 2020 · 7 comments · Fixed by #4164
Closed

Fix file friendly logging #3785

brendan-ai2 opened this issue Feb 14, 2020 · 7 comments · Fixed by #4164
Assignees
Milestone

Comments

@brendan-ai2
Copy link
Contributor

brendan-ai2 commented Feb 14, 2020

@OyvindTafjord has identified a bug in our (formerly) file friendly logging that originated during the DistributedDataParallel additions. In short, --file-friendly-logging does not appear to work anymore.

To quote his Slack message:

Regarding the lack of file-friendly logging: I'm guessing it's the distributed code (#3529). As a workaround I hacked in the earlier code and that now works for my purposes (OyvindTafjord@8a1c7ad). I also note that another change was that the stderr.log file for better or worse used to record these tqdm statuses, but with the new code that doesn't seem to happen (maybe that was intentional, but occasionally I have made use of those to get a post-hoc rough "training curve", although when using beaker those are also in the main beaker log).

@brendan-ai2 brendan-ai2 added this to the 1.0.0 milestone Feb 14, 2020
@schmmd schmmd self-assigned this Feb 14, 2020
@dirkgr
Copy link
Member

dirkgr commented Feb 21, 2020

Should be fixed with #3519.

@dirkgr dirkgr removed the Triage label Feb 21, 2020
@schmmd
Copy link
Member

schmmd commented Feb 22, 2020

@dirkgr thanks--I have not had time to look at this yet...

@matt-gardner
Copy link
Contributor

@schmmd, we talked about this in our issue triage, and thought it should be covered by work I'm planning for #3519, so you shouldn't have to worry about this.

@schmmd
Copy link
Member

schmmd commented Mar 6, 2020

How would we validate that this is indeed fixed now that #3519 is merged?

@DeNeutoy
Copy link
Contributor

DeNeutoy commented Mar 6, 2020

Now the issue that this is tracking with is #3913 , so it isn't fixed yet...

@schmmd
Copy link
Member

schmmd commented Mar 23, 2020

This is independent of the other PRs and needs attention.

@matt-gardner
Copy link
Contributor

Because there's some example code already that probably fixes the issue, I'm giving this one a "day" label. Could be much less, if that example code just works without much effort, I just don't know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants