Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

Polish the Hierplane integration into the AllenNLP demo. #63

Closed
codeviking opened this issue Nov 22, 2017 · 4 comments
Closed

Polish the Hierplane integration into the AllenNLP demo. #63

codeviking opened this issue Nov 22, 2017 · 4 comments
Assignees

Comments

@codeviking
Copy link
Contributor

There are some UX / UI issues associated with the integration of Hierplane into the AllenNLP demo. We should:

  • Fix these.
  • Add options / incorporate changes into the library itself where appropriate.
@codeviking
Copy link
Contributor Author

This can't be accomplished until allenai/allennlp#526 lands.

@DeNeutoy
Copy link

Adding a few minor style things here for the polish:

Is it possible to make the text inside the boxes wrap, so that the full tree fits in the space?
screen shot 2017-11-22 at 9 43 52 am

The box containing the passage could be bigger, so that you can see all of the text for long sentences without having to scroll.
screen shot 2017-11-22 at 9 42 06 am

@aaronsarnat
Copy link
Contributor

Seems like these problems have been addressed and this issue can be closed. @codeviking would you concur?

@codeviking
Copy link
Contributor Author

Yup, we're good to go in this regard!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants