Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% likely that two function parameters have been merged by accident #16

Open
JulesGM opened this issue Nov 29, 2022 · 1 comment
Open

100% likely that two function parameters have been merged by accident #16

JulesGM opened this issue Nov 29, 2022 · 1 comment
Labels
code enhancement Code fix for better readability and maintenance with no new features good first issue Good for newcomers

Comments

@JulesGM
Copy link
Contributor

JulesGM commented Nov 29, 2022

https://github.com/allenai/RL4LMs/blob/main/rl4lms/envs/text_generation/policy/seq2seq_policy.py#L263

Screen Shot 2022-11-29 at 6 05 29 PM
@rajcscw
Copy link
Contributor

rajcscw commented Dec 1, 2022

Oh right. This seems like a merging issue. The good thing is that argument is unused/overridden at the moment. That is why it still works without any run-time errors.

@rajcscw rajcscw added good first issue Good for newcomers code enhancement Code fix for better readability and maintenance with no new features labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code enhancement Code fix for better readability and maintenance with no new features good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JulesGM @rajcscw