Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spaCy 3.0 #303

Closed
davidmezzetti opened this issue Feb 2, 2021 · 8 comments · Fixed by #295
Closed

Support spaCy 3.0 #303

davidmezzetti opened this issue Feb 2, 2021 · 8 comments · Fixed by #295

Comments

@davidmezzetti
Copy link

davidmezzetti commented Feb 2, 2021

spaCy was upgraded to 3.0 this week and it appears the current version of scispacy is incompatible. I see there is a spacy3 branch and #295 appears to be a WIP on the upgrade.

Looks like a big pull on the move to 3.0. Do you have an idea on the timeline for the upgrade? Thank you for putting this project out there!

Here is the stack using a Python 3.8 virtualenv with spacy 3.0.1 and en_core_sci_md 0.3.0 installed.

>>> import en_core_sci_md
/tmp/test/lib/python3.8/site-packages/spacy/util.py:715: UserWarning: [W094] Model 'en_core_sci_md' (0.3.0) 
specifies an under-constrained spaCy version requirement: >=2.3.1. This can lead to compatibility problems with 
older versions, or as new spaCy versions are released, because the model may say it's compatible when it's not. 
Consider changing the "spacy_version" in your meta.json to a version range, with a lower and upper pin. 
For example: >=3.0.1,<3.1.0
  warnings.warn(warn_msg)
>>> en_core_sci_md.load()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/tmp/test/lib/python3.8/site-packages/en_core_sci_md/__init__.py", line 10, in load
    nlp = load_model_from_init_py(__file__, **overrides)
  File "/tmp/test/lib/python3.8/site-packages/spacy/util.py", line 514, in load_model_from_init_py
    return load_model_from_path(
  File "/tmp/test/lib/python3.8/site-packages/spacy/util.py", line 388, in load_model_from_path
    config = load_config(config_path, overrides=dict_to_dot(config))
  File "/tmp/test/lib/python3.8/site-packages/spacy/util.py", line 545, in load_config
    raise IOError(Errors.E053.format(path=config_path, name="config.cfg"))
OSError: [E053] Could not read config.cfg from /tmp/test/lib/python3.8/site-packages/en_core_sci_md/
en_core_sci_md-0.3.0/config.cfg
@dakinggg
Copy link
Collaborator

dakinggg commented Feb 2, 2021

Yes, please see #295. It is in progress, thanks!

@davidmezzetti
Copy link
Author

Appreciate the rapid response, thank you! Please feel free to close this issue if you feel it's duplicative.

@dakinggg
Copy link
Collaborator

dakinggg commented Feb 2, 2021

I'll leave it open until we merge the PR so that other people can find it easily :)

@dakinggg
Copy link
Collaborator

dakinggg commented Feb 5, 2021

Slightly premature closing. We've uploaded new models that are compatible with master (and spacy 3), but haven't quite done a release yet. If you need it urgently, you should be able to use master and the new models. Otherwise, we should be doing a release sometime in the next week or so.

@davidmezzetti
Copy link
Author

Thank you for the quick response and turnaround, appreciate it!

@dnm1977
Copy link

dnm1977 commented Feb 5, 2021

Anxiously awaiting, as well. Thank you.

@dakinggg
Copy link
Collaborator

Release released!

@davidmezzetti
Copy link
Author

Great, thank you for the rapid turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants