Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default protocol bug #116

Closed
ghost opened this issue Mar 13, 2022 · 3 comments · Fixed by #123
Closed

default protocol bug #116

ghost opened this issue Mar 13, 2022 · 3 comments · Fixed by #123
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Mar 13, 2022

if len(e) > 0 {

当e切片长度不为0时,已经将数据拷贝进UserBuffer了,但是并没有将buffer *ringbuffer.RingBuffer清空?这是为什么?

@Allenxuxu Allenxuxu added the bug Something isn't working label Mar 17, 2022
@Allenxuxu
Copy link
Owner

这边确实有问题,遗漏了Retrieve(n) , 感谢指出🙏

@woshihuo12
Copy link

return nil, userBuffer

还想问下,这个拷贝到userBuffer的数据,外面使用的时候,是如何知道其有效长度的呢?

@Allenxuxu
Copy link
Owner

return nil, userBuffer

还想问下,这个拷贝到userBuffer的数据,外面使用的时候,是如何知道其有效长度的呢?

这里也有问题,应该userBuffer[:size], 我一起修复了 https://github.com/Allenxuxu/gev/pull/123。
非常感谢两位🙏。

@Allenxuxu Allenxuxu linked a pull request Apr 3, 2022 that will close this issue
@Allenxuxu Allenxuxu changed the title 这里是不是错了 default protocol bug Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants