Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow breakpoint of [0,0] #46

Closed
mboynes opened this issue May 5, 2016 · 2 comments
Closed

Allow breakpoint of [0,0] #46

mboynes opened this issue May 5, 2016 · 2 comments
Assignees
@mboynes
Labels
bug Something isn't working

Comments

@mboynes
Copy link
Contributor

mboynes commented May 5, 2016

DFP's docs on building responsive ads says:

A browser size mapping of [0, 0] can be used to specify a default mapping that can be used on any browser size.

Setting a width and height of 0 doesn't work in Ad Layers. You can set it to be [1,1] which works just as well, but [0,0] should be supported.

The underlying bug is upstream in alleyinteractive/wordpress-fieldmanager#493.
@mboynes mboynes self-assigned this May 5, 2016
@mboynes mboynes added the bug Something isn't working label May 5, 2016
@Souvent22
Copy link
Contributor

I created a PR for this issue:

#47

@mboynes
Copy link
Contributor Author

mboynes commented Apr 5, 2017

Fixed in alleyinteractive/wordpress-fieldmanager#500.

@mboynes mboynes closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mboynes mboynes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Souvent22 @mboynes