Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Move print of warnings to the end #18

Closed
MilosMosovsky opened this issue May 21, 2016 · 3 comments
Closed

Move print of warnings to the end #18

MilosMosovsky opened this issue May 21, 2016 · 3 comments

Comments

@MilosMosovsky
Copy link

MilosMosovsky commented May 21, 2016

Hello, i started to use this plugin, but when any warning/error is printed to the console it is printed to the end of webpack stack like this, and i have to scroll 400 lines to the up to see real warnings

screenshot 2016-05-22 01 07 08

I was experimenting with this source

// Hook into the compilation as early as possible, at the seal step
    compilation.plugin('seal', function() {
      // We need to keep the reference to the compilation's scope
      var _this = this;

      // Errors/Warnings are pushed to the compilation's error handling
      // so we can drop out of the processing tree on warn/error
      report.forEach(function(x) {
        if(x.error) {
          _this.errors.unshift(x.file);
        } else {
          _this.warnings.unshift(x.file);
        }
      });

and changed seal to the done now i get expected result in console
screenshot 2016-05-22 01 09 21

Is there any particular reason to hook into seal step? If not it is possible to change this or open PR with this? Thanks

@jackmarketon
Copy link
Contributor

No there is not, you are welcome to submit a PR for this.

@jackmarketon
Copy link
Contributor

This has been fixed and deploying shortly here

@kevincaradant
Copy link

kevincaradant commented Sep 15, 2016

@jackmarketon Hi, I get the same problem to display the real warnings like @MilosMosovsky , is it fix in the last version ? thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants