Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge needed features #44

Closed
abgit opened this issue Nov 1, 2013 · 12 comments
Closed

merge needed features #44

abgit opened this issue Nov 1, 2013 · 12 comments

Comments

@abgit
Copy link
Contributor

abgit commented Nov 1, 2013

hi all,
When can we see all features already made in stable version?

  • countries (isocode+name) module;
  • continents (isocode+name) module;
  • daily requests module;
  • csv output export
  • isatty detection fix / force output

Some features have more than 2 month old.. and in my case are required to turn goaccess useful.

best,
Francisco Azevedo

@allinurl
Copy link
Owner

allinurl commented Nov 2, 2013

Will merge some of these over the weekend. Thanks for the follow up.

@abgit
Copy link
Contributor Author

abgit commented Nov 3, 2013

Hi @allinurl, in fact those features are very important. Hope to see them ported/merged to stable.
If you need help let me know.

Best,
Francisco Azevedo

@abgit
Copy link
Contributor Author

abgit commented Nov 4, 2013

Hi @allinurl , nice to see csv support now on stable. Thanks.
Can you port/merge countries and continents modules to stable too?

best,
Francisco Azevedo

@allinurl
Copy link
Owner

allinurl commented Nov 4, 2013

abgit, will be working on that this week. Thanks!

On Mon, Nov 4, 2013 at 3:50 AM, abgit notifications@github.com wrote:

Hi @allinurl , nice to see csv support now on stable. Thanks.
Can you port/merge countries and continents modules to stable too?

best,
Francisco Azevedo


Reply to this email directly or view it on GitHub.

@abgit
Copy link
Contributor Author

abgit commented Nov 7, 2013

Hi @allinurl , thanks for you commitment 👍
Countries & Continents are really useful.

About this topic, seems that stable version don't has the geoip optimizations included in unstable version and geoip flag choice. On stable we init a geo_ip object for each log item.. instead of init geoip once and only apply one call to that global geoip object per log item.
This was already discussed and "fixed" on unstable version.
Hope to get this performance boost using a global GeoIP and geoip memory flag to change from geoip_standard to geoip_memory_cache on stable version too.

Best,
Francisco Azevedo

@allinurl
Copy link
Owner

allinurl commented Nov 7, 2013

Will merge the Countries & Continents as I mentioned before. Though, I'm thinking to use GEOIP_STANDARD as the default option to minimize memory usage and have a flag for GEOIP_MEMORY_CACHE. Not sure yet.

@abgit
Copy link
Contributor Author

abgit commented Nov 7, 2013

That optional flag would be excellent. In my case, memory for geoip is not a problem.. a slow goaccess is a problem. :)

@allinurl
Copy link
Owner

Added Geolocation to the HTML output.

@abgit
Copy link
Contributor Author

abgit commented Nov 18, 2013

@allinurl , can you add geolocation csv & json export?

best,
Francisco Azevedo

@allinurl
Copy link
Owner

Geolocation is being added to csv & json export. Though, sub items for certain modules were missing. Will add those.

@abgit
Copy link
Contributor Author

abgit commented Nov 29, 2013

@allinurl , can you add geolocation info to csv/json ?

Thanks

Best,
Francisco Azevedo

@allinurl
Copy link
Owner

This has been added. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants