Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with tweak scale mod #4

Closed
Jiraiyah opened this issue Oct 2, 2016 · 10 comments
Closed

Problem with tweak scale mod #4

Jiraiyah opened this issue Oct 2, 2016 · 10 comments
Assignees

Comments

@Jiraiyah
Copy link

Jiraiyah commented Oct 2, 2016

Hi
I found that tweak scale mod was not working and I narrowed down the problem and found that when your mod is outside of game data folder, tweak scale behaves, as soon as i add your mod back, it stops working, is this a known issue or new?
here is the link for original problem in tweak scale forum post :
http://forum.kerbalspaceprogram.com/index.php?/topic/99956-wip-tweakscale-development-thread/&do=findComment&comment=2783637
and here is the output log just in case it would help :
https://www.dropbox.com/s/r9a9l91ktxxcbmb/output_log.zip?dl=0

@allista allista self-assigned this Oct 2, 2016
@allista
Copy link
Owner

allista commented Oct 2, 2016

I don't know what's going on there, but you have A LOT of exceptions telling that Assembly Loader cannot load many different mods. And none of them point to the ALG; nor can it affect assembly loading process in any way.
So I would guess there's something wrong with the installation, versions, etc.

@Jiraiyah
Copy link
Author

Jiraiyah commented Oct 2, 2016

No, I tried tweak scale with a new instance of ksp, it worked, added your mod and it didn't work, for some reason, it looks like tweak scale does something in the loading screen or the game instance launch screen that your mod is bypassing it? maybe talk to developer of tweak scale about this? or if you need, i can use that pure instance to get a cleaner output log for you

@allista
Copy link
Owner

allista commented Oct 2, 2016

Yea, cleaner output log would be great.
I'll look into TS code tomorrow.
ALG does the same thing KSP does when you load the game manually. It just does this as soon as the main screen have been loaded. So in principle it may interfere with something that starts at the same time and tries to do some work...

@Jiraiyah
Copy link
Author

Jiraiyah commented Oct 2, 2016

OK, take a look at this image, this is the folder, as you see i just added a simple module manager patch to tweak the module for tweak scale on orbital survey
http://prntscr.com/cp320d
now here is the output file
https://www.dropbox.com/s/lrvnnxjuw5sb7hd/output_log.zip?dl=0
the result again is the same as what you can see in screen shots in the forum posts i sent the link to you

@pellinor0
Copy link

Not sure what fails here but it should fail more gracefully. I'll also have a look.

Module TweakScale threw during OnStart: System.NullReferenceException: Object reference not set to an instance of an object
  at TweakScale.ScaleExponents.CreateExponentsForModule (.ConfigNode node, System.Collections.Generic.Dictionary`2 parent) [0x00000] in <filename unknown>:0 
  at TweakScale.ScaleType..ctor (.ConfigNode partConfig) [0x00000] in <filename unknown>:0 
  at TweakScale.TweakScale.Setup () [0x00000] in <filename unknown>:0 
  at TweakScale.TweakScale.OnStart (StartState state) [0x00000] in <filename unknown>:0 
  at Part.ModulesOnStart () [0x00000] in <filename unknown>:0 

(Filename: C:/buildslave/unity/build/artifacts/generated/common/runtime/UnityEngineDebugBindings.gen.cpp Line: 64)
Module TweakScale threw during OnStart: System.NullReferenceException: Object reference not set to an instance of an object
  at TweakScale.ScaleExponents.CreateExponentsForModule (.ConfigNode node, System.Collections.Generic.Dictionary`2 parent) [0x00000] in <filename unknown>:0 
  at TweakScale.ScaleType..ctor (.ConfigNode partConfig) [0x00000] in <filename unknown>:0 
  at TweakScale.TweakScale.Setup () [0x00000] in <filename unknown>:0 
  at TweakScale.TweakScale.OnStart (StartState state) [0x00000] in <filename unknown>:0 
  at Part.ModulesOnStart () [0x00000] in <filename unknown>:0 

@Jiraiyah do you need your custom patch to make it fail? If it is the one from the TweakScale thread, I just noticed that
%SCALETYPE {...}
looks suspicious to me. I only know this syntax in the form
%SOMETHING[name] {...}
which either creates or edits a node of type SOMETHING with the given name. Since you are creating a new scaleType you probably want to leave out the %.

@Jiraiyah
Copy link
Author

Jiraiyah commented Oct 3, 2016

not really, even without the patch it fails

@Jiraiyah
Copy link
Author

Jiraiyah commented Oct 3, 2016

the only reason i had that % in front of scale type was that i was not sure if it would work without it or not, i am not that familiar with patching with module manager myself. but even without my patch it is still broken

@allista
Copy link
Owner

allista commented Oct 27, 2016

This may be fixed in 996caf4.
I had a similar problem with TAC LifeSupport that was fixed by that commit.

@Jiraiyah
Copy link
Author

still didn't check it, but interesting, Awake() would be called as soon as the scripts are being loaded to the game, yah, that may have fixed it ;) will give it a try and tell you the result later

@Jiraiyah
Copy link
Author

confirmed the fix on tweak scale, thanks sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants