Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using outfits and reflections in version 1.1.1 not working right #153

Closed
tobbi64 opened this issue Oct 24, 2021 · 2 comments
Closed

Using outfits and reflections in version 1.1.1 not working right #153

tobbi64 opened this issue Oct 24, 2021 · 2 comments
Labels

Comments

@tobbi64
Copy link

tobbi64 commented Oct 24, 2021

Describe the bug

  1. The Stocking Shape in the Outfit settings, only effects the Stocking Surface and not the Masked Surface anymore.
  2. And as the “Masked Surface ” the “original” doesn’t work anymore.
  3. Strange artificing under characters with reflections on
    (See Videos)

To Reproduce
Steps to reproduce the behavior:
Problem 1:

  1. Go to Outfits in a character
  2. Select an tattoo
  3. select an masked Surface and change the Stocking shape
  4. See how the Stocking Surface changes but the Masked Surface doesn’t.

Problem 2:

  1. Go to Outfits in a character
  2. Select an tattoo
  3. select an masked Surface
  4. you will notice that everything works except “Original” witch should be the original color (skin)

Problem 3:

  1. Go to graphics and set it to high. Then you see a strange area between character and the ground. (see video)
  2. Also when you look from horizontal to the floor you see an “line” where the reflections stop to work (sec 14-16 in vid 3)

videos
Problem 1+2:
I have loaded the same scene in 1.1.0 and 1.1.1
You can see in version 1.1.0 it works as expected “Original” is the skin color and the Stocking Shape effects the Stocking Surface and the Masked Surface
In version 1.1.0 however it doesn’t.

Version 1.1.0:

Outfit.Version.1.1.0-1.mp4

Version 1.1.1

Outfit.Version.1.1.1-1.mp4

Problem 3:
(strange area between character and the ground when reflections on)

Reflections-1.mp4

Desktop (please complete the following information):

  • OS: Win 10
  • Browser chrome
  • Version DanceXR HD Pro_win64_1.1.1.339
@tobbi64 tobbi64 changed the title Using outfits in version 1.1.1 not working right Using outfits and reflections in version 1.1.1 not working right Oct 24, 2021
@alloystorm
Copy link
Owner

Thank you for taking the time writing the descriptions and making the videos. That's great effort!

The outfit shader has been modified in the 1.1.1 release to optimize the flow and reduce rendering cost. In doing so certain behaviour is sacrificed to make way for performance and simplicity. From your description the problem 1 is due to the masking area is not limited by the stocking shape, and 2 is due to the way color is generated. We'll review these again and see how much can we bring back.

The problem 3 is SSR defect, this is just the technical limitation of screen space reflection. Use probe reflection will eliminate this but at a greater performance cost.

@alloystorm alloystorm added the wip Work in progress label Nov 7, 2021
@alloystorm
Copy link
Owner

Fixed in 1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants