Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inject return type hint #40

Merged
merged 1 commit into from Jul 29, 2020

Conversation

roo-oliv
Copy link
Owner

@roo-oliv roo-oliv commented Jul 29, 2020

Fix #37

This PR fixes the type hint for method inject and also adds a usage example of the low-level API methods inject and inject_multiple.

Co-authored-by: Roman Gräf roman.graef@gmail.com @romangraef

Co-authored-by: Roman Gräf <roman.graef@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@roo-oliv roo-oliv self-assigned this Jul 29, 2020
@roo-oliv roo-oliv added the bug Something isn't working label Jul 29, 2020
@roo-oliv roo-oliv marked this pull request as ready for review July 29, 2020 15:47
@roo-oliv roo-oliv merged commit b173c55 into master Jul 29, 2020
@roo-oliv roo-oliv deleted the allrod5/fix-inject-return-type-hint/fix-#37 branch July 29, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] inject method signature accepts T instead of Type[T]
1 participant