Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nationwide_gb spider missing branches (regex not general enough) #4282

Closed
rjw62 opened this issue Dec 6, 2022 · 1 comment · Fixed by #4285
Closed

nationwide_gb spider missing branches (regex not general enough) #4282

rjw62 opened this issue Dec 6, 2022 · 1 comment · Fixed by #4285

Comments

@rjw62
Copy link
Contributor

rjw62 commented Dec 6, 2022

According to e.g. https://www.altfi.com/article/9347_nationwide-pledges-to-keep-its-625-branches-open-until-2024 Nationwide should have 625 UK branches. The current nationwide_gb spider is only returning 549.

One issue that is probably behind most (if not all) of the missing branches is that the regex r"https:\/\/www\.nationwide\.co\.uk\/branches\/[-()\w]+\/[-\w]+$" used to detect branch page URLs is not sufficiently general. In addition to word characters and hypens the final (branch) part of the URL can also contain a forward slash (used to denote house-number ranges).

For example: https://www.nationwide.co.uk/branches/northampton/18/19-weston-favell-centre

@Cj-Malone
Copy link
Contributor

Cj-Malone commented Dec 6, 2022

I don't know about the 625 number, but I count 629 with 22 "permanently closed", so 607.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants