Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Show class inheritance and member overrides indicator #111

Closed
markvandenbrink opened this issue May 26, 2016 · 3 comments
Closed
Assignees

Comments

@markvandenbrink
Copy link

Hi @basarat,

I discovered your UML class diagram feature in ALM (really nice!) and since it can show the base class which it extends it reminded me to an "old" feature request/discussion in the atom-typescript project (see TypeStrong/atom-typescript#464).

Wouldn't it be great if you can show an indicator in the left margin of the code editor for class inheritance and member overrides (possibly with a jump to declaration on click). Just like Visual Studio does for languages like C++, C#, etc. I think it would be very useful to see a visual clue...

Big thanks for all your hard work for the TypeScript community as a whole and your efforts in creating the best TypeScript IDE! Really appreciate it.

@basarat basarat self-assigned this May 26, 2016
@basarat
Copy link
Member

basarat commented May 26, 2016

I've done it for does this override any parent as I could do that performantly quite easily (only requires current file analysis). That provides sufficient value (at least you know if you've mistyped something).

overrides

The "is this member overridden by anything* is a bigger task in terms of its performance impact (all classes need to be analyzed) and I will think about that more.

Released with 0.0.75 🌹

@markvandenbrink
Copy link
Author

markvandenbrink commented May 27, 2016

Wow, very nice!!! I think the "does this override any parent" is the most useful indicator. So this is great for now. Do you think this feature could be easily integrated in atom-typescript as well (I understand your main focus is now on ALM, but I'm just curious)? Or is it hard to show custom indicators in Atom?

I noticed one small bug regarding the position of the indicator. If a member is preceded by a comment block, the indicator is displayed at the beginning of the comment block instead of the member declaration.

@basarat
Copy link
Member

basarat commented May 27, 2016

Or is it hard to show custom indicators in Atom

Its just as easy https://basarat.gitbooks.io/alm/content/contributing/why.html 🌹

If a member is preceded by a comment block, the indicator is displayed at the beginning of the comment block

image

Fixed aea79c4 0.0.80 🌹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants