Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FakeConsumer consume does not match confluent kafka API #63

Closed
markjbyrne opened this issue Apr 9, 2024 · 2 comments
Closed

FakeConsumer consume does not match confluent kafka API #63

markjbyrne opened this issue Apr 9, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@markjbyrne
Copy link

markjbyrne commented Apr 9, 2024

Describe the bug

The consume function of the FakeConsumer class returns either a Message or None. This doesn't meet the confluent-kafka spec which lists the return type as list([Message])

Expected behavior
list(Message) is returned

@markjbyrne markjbyrne added the bug Something isn't working label Apr 9, 2024
@alm0ra alm0ra self-assigned this Apr 9, 2024
@alm0ra
Copy link
Owner

alm0ra commented Apr 10, 2024

@markjbyrne, thank you for bringing up this issue.

As discussed in #65, we had initially envisioned simplifying the project, which led to the inability to consume multiple messages without committing them.

By resolving this issue, we'll also address the current concern.

Additionally, we have now implemented a consume method that functions similarly to .poll() methods and returns just one message.

@alm0ra
Copy link
Owner

alm0ra commented Apr 16, 2024

issue fixed in v0.1.55

@alm0ra alm0ra closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants