New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less compilation failed after installing v2.4 from bower #1665

Closed
gauravdaxini opened this Issue Oct 3, 2017 · 12 comments

Comments

Projects
None yet
10 participants
@gauravdaxini

gauravdaxini commented Oct 3, 2017

We have been using the admin-lte from quite long time. But, when we build our app last week and compiled the LESS file which depends on admin-lte LESS files, it failed.

ERROR

$ lessc assets/css/less/app.less assets/css/app.min.css --clean-css="--s1"
FileError: '../../../bower_components/bootstrap/less/mixins.less' wasn't found. Tried - {project_path}\assets\vendor\admin-lte\bower_components\bootstrap\less\mixins.less,{project_path}\bower_components\bootstrap\less\mixins.less,..\..\..\bower_components\bootstrap\less\mixins.less in {project_path}\assets\vendor\admin-lte\build\less\skins\skin-blue-light.less on line 5, column 1:
4  */
5 @import "../../../bower_components/bootstrap/less/mixins.less";
6 @import "../../../bower_components/bootstrap/less/variables.less";

Since bower installed the latest admin-lte(v2.4) which does not include the bower-components folder, when we compiled the LESS file it didn't get the bootstrap mixins and variables file from bower_components folder.

Please help to fix this.

@jake-harris

This comment has been minimized.

jake-harris commented Oct 4, 2017

I'm also getting this issue when installing via NPM.

@acacha

This comment has been minimized.

acacha commented Oct 4, 2017

Same problem here!

@vingrad

This comment has been minimized.

vingrad commented Oct 5, 2017

same problem.

@vingrad

This comment has been minimized.

vingrad commented Oct 5, 2017

This will fix the problem.

cd node_modules\admin-lte
bower install

@elboletaire

This comment has been minimized.

elboletaire commented Oct 6, 2017

Also, why the hell are all the bower_components packaged with the plugin? This is insane 😞

@elboletaire

This comment has been minimized.

elboletaire commented Oct 6, 2017

BTW, In my case I forced the version to be 2.3.11.

almasaeed2010 added a commit that referenced this issue Oct 8, 2017

@almasaeed2010

This comment has been minimized.

Owner

almasaeed2010 commented Oct 8, 2017

Fixed in master by providing bootstrap less files in the build directory.

Thanks for reporting the issue!

@THETCR

This comment has been minimized.

THETCR commented Oct 10, 2017

This issue should be opened again, since you missed line 11 & 12 in bootstrap-social.less and so the npm version still fails. No less files from this projects should reference less files from the bower components. Especially not since the bootstrap less files are already in the build folder.

@gauravdaxini

This comment has been minimized.

gauravdaxini commented Oct 18, 2017

Thanks @almasaeed2010 for providing a quick fix. However, I'm still facing the issue.

You have forgotten to update the bootstrap less dependency PATH in skin's less file (some less file still contains ../../../bower_components/bootstrap/less/mixins.less path which does not exist) which is causing the failure while compiling the less file.

Please help to fix this.

@LLNet

This comment has been minimized.

LLNet commented Oct 20, 2017

Fix works fine for me.

from : ../../bower_components/bootstrap/less/mixins
if you have own in bower bootstrap: ../../../bootstrap/less/mixins
if not: ../bootstrap-less/mixins

same for variables

@ernestodgr

This comment has been minimized.

ernestodgr commented Dec 23, 2017

the npm run dev command works well after doing what it says @vingrad, but now it happens that the menu does not work well

@FredWillson

This comment has been minimized.

FredWillson commented Apr 4, 2018

cd node_modules\admin-lte
bower install

What am i supposed to do with non stop "ECMDERR Failed to execute git ls-remote...." errors on random packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment