Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open LocationPickerViewController #25

Closed
AlexZd opened this issue Oct 1, 2016 · 4 comments
Closed

open LocationPickerViewController #25

AlexZd opened this issue Oct 1, 2016 · 4 comments

Comments

@AlexZd
Copy link

AlexZd commented Oct 1, 2016

Now it is public, in this case I can't inherit it, better to use open
@almassapargali
Copy link
Owner

It's made 'public' intentionally, it's not meant to be subclasses. What are you trying to achieve by subclassing?

@AlexZd
Copy link
Author

AlexZd commented Oct 1, 2016

Need to make some additional setting in viewDidLoad and viewWillAppear

@TripwireNL
Copy link

I'd like to have it open as well since I use your controller in Eureka forms to make a custom LocationPicker row

@almassapargali
Copy link
Owner

Ok guys, it's open now, please use version 1.0.2.

Vincent-Loi pushed a commit to Vincent-Loi/LocationPicker that referenced this issue Nov 9, 2017
Merge branch 'master' of https://github.com/almassapargali/LocationPi…
2caf001 
…cker

* 'master' of https://github.com/almassapargali/LocationPicker:
  Release 1.0.3
  Use new bundle id for signing
  Ignore cancelGeocode errors, fixes almassapargali#34
  Allow to select current location, close almassapargali#13, close almassapargali#26, close almassapargali#32
  bump version
  make LocationPickerViewController open, closes almassapargali#25
  added swift verison and bump verison

# Conflicts:
#	Demo/LocationPickerDemo.xcodeproj/project.pbxproj
#	LocationPicker/LocationPickerViewController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@almassapargali @TripwireNL @AlexZd