Set / Remove / Update Assignments in Detail View [13]

[michaelkleinhenz]

Reference: 1608E068

Description

As a user, I want to set, update and remove assignments of work items to users in the work item detail view.
UX desgins #40
Updated UX designs #53

Functional Acceptance Criteria

1. On the work item detail view, the current assigned user ("assignee") can be viewed.
2. The default value is the empty/undefined value ("not assigned").
3. The user can set/change the assignee by typing an id into an input field.
4. It is possible to change the assignee to the empty/undefined value ("not assigned"). This choice is always visible.
5. The new/changed selected assignee is instantly displayed on the view.
6. Changes are saved by clicking on the save button, not in-place.

Note: there is no search on users in a typeahead field in this story. The requirements only specify entering an user id (which is a non-human-readable id) in full. Entering an unknown user id results in an error. A later story will specify the typeahead search for user names. Note that anything that is implemented beyond the requirements of this story is optional, but not required.

Note: in the context of this story, only one assignee can be added to the work item. We will need more that one assignee later, because these will be attached to "roles" like "assigned to", "reported by" or similar. This will be added later with a different story.

Non-Functional Acceptance Criteria

1. The matching of possible assignees in the searchfield is done in a performant way.

Tasks

• Display current assignee on the work item detail view fabric8-ui/fabric8-planner#284
• Create a service to fetch the list of users from core fabric8-ui/fabric8-planner#285
• Update work item service to set system.assignee to selected UUID or null fabric8-ui/fabric8-planner#286
• Develop the UI for setting/unassign a user as assignee fabric8-ui/fabric8-planner#288
• Add secured GET API to list existing users of the system Add secured GET API to list existing users of the system. #467
• Modify WorkItem Update api to set assignee Modify WorkItem Update api to set assignee  #466

[pranavgore09]

Hello @michaelkleinhenz, Apart from the description (and google calendar :) ) above is there anything I should look at, means any UI/UX work already done or in progress, invision docs etc etc.

[michaelkleinhenz]

@pranavgore09 checking with UX if the story matches with their current thoughts makes definitely sense.

[pranavgore09]

Sure @michaelkleinhenz , thank you.
@mindreeper2420, @Mgranfie : Will you please let me know if there is anything being done or already done regarding assignments from UX team ? I will read up and link them here.

[Mgranfie]

Adam... has been working on this feature, will loop him in here.

We do have UX solution for Assign user to a work item. I am not sure what
work has been done on Unassign and will hand off to Adam here.

On Fri, Oct 28, 2016 at 4:11 AM, Pranav Gore notifications@github.com
wrote:

Sure @michaelkleinhenz https://github.com/michaelkleinhenz , thank you.
@mindreeper2420 https://github.com/mindreeper2420, @Mgranfie
https://github.com/Mgranfie : Will you please let me know if there is
anything being done or already done regarding assignments from UX team ?
I will read up and link them here.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#341 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARTwq_vDQEJ9ic1Gz_YthLgL5QAURJXLks5q4a43gaJpZM4KOxyj
.

[AdamJ]

@pranavgore09 @michaelkleinhenz @Mgranfie Assign User can be found here: Almighty-ux#40

The proper flow for Assign and Unassign are in the mobile workflow/wireframe view. The Desktop layout is in the Desktop view.

[pranavgore09]

Thank you @mindreeper2420 @Mgranfie for the inputs.

[pranavgore09]

From invision link I could understand following items are involved for making assignments.

• Self assignment
• Selection from type-ahead and assign to another user.
• Invite non-system users via email. @mindreeper2420, @Mgranfie : any workflow for inviting via email I can look at ? ( @maxandersen , @michaelkleinhenz are we considering this for short term goal or upcoming sprint ?)
• Cancel assignment

Verification criteria mentioned here talks about assign to team members. @maxandersen, @michaelkleinhenz Are we considering this task (Basically having Teams in the system) for short term goal ?

[michaelkleinhenz]

@pranavgore09 Teams will be a different set of stories. Also, the email stuff is not currently part of the story, as this is complex, also from the hosting perspective. There are some ongoing talks about that if I correctly remember (especially about using a REST->E-Mail provider instead of SMTP).

[pranavgore09]

@mindreeper2420 @Mgranfie Just asking out of curiosity if we are supporting keyboard short-cuts for assignments. (e.g> On github issue, when typed a, focus goes to assigment ; when typed s, focus goes to search bar. )

@michaelkleinhenz : for clarity, as you mentioned dropdown to select user in the description, is it same as type-ahead ? Or there should be a dropdown with all possible users, and as we type in the name, list will be shortened as per the match (without search request to core).

Technical task distribution (once reviewed, I will update in main description)

• UX
  • Ability to view and assign WI to a system user fom detail page.
• UI
  • Update UI for list view / detail view to show assignments
  • Consume core APIs and perform CREATE/UPDATE/DELETE on Assignments
  • Provide user with type-ahead while searching with user name/email during assigmnent. (TBD)
• Core
  • API for assigment (CREATE/UPDATE/DELETE) [Set SystemAssignee in WI.Fields]
  • API should allow self assignment.
  • DELETE API should remove current assigned user from WI.
  • Update search API for type ahead search on type=user (TBD)

@maxandersen @michaelkleinhenz Please verify once if I am not adding unnecessary tasks or not missing any.

[michaelkleinhenz]

@pranavgore09 on the dropdown: no search in this story as this is a whole epic making entities searchable. So no typeahead. We'll add that in a later story.
On the task list: cool, that's exactly what we'll need for SP2. So this would be an "input" to the SP2 discussion. After that you will have a validated task list that can be "converted" into GitHub issues.

[AdamJ]

@pranavgore09 @michaelkleinhenz the only keyboard shortcuts that we are taking into account are Enter and Esc for finalizing / canceling an action. All other keyboard shortcuts will be looked at in the future.

[pranavgore09]

@michaelkleinhenz @mindreeper2420 Thanks, I will update Story accordingly.

[pranavgore09]

Story: Assignments of WI to system users #341 (Owner: Pranav Gore)

Assumptions - (@maxandersen @michaelkleinhenz Please verify items below)

• No invite via email
• Assign and Unassign one users at a time
• No searching using APIs (no typeahead, all users will be given to client via single GET call)
• Assign to existing system users only

UX- (@mindreeper2420 Please verify items below)

• Already Done here
• Mobile Wireframe and Desktop Wireframe
• No pending tasks

UI- (@nimishamukherjee please verify items below)

• New service to fetch list of users (one time call on_page_load)
• Modify existing workItem-update service to set "system.assignee" in the WI. Fields (value=UUID/nil)
• create interface for input_box+search+dropdown with two buttons at bottom, to display user list and then assign selected user.
• Show existing assignee name/handle as applicable in detail view

Core- (@aslakknutsen , @tsmaeder Please verify items below)

• Secured GET API to list existing users of the system.
• Modifications in WorkItem UPDATE APi to absorb valid set of values for SystemAssignee.
  Possible values are Nil/Valid_system_user_uuid(including self).

ToDo:

• Decide a strategy to push newly added user to clients

Pending Questions: (answers will be collected from 1, 2, 3)

• Are all wireframes ready to kick off development ?
• Do we need to click on save button to make REST call ? reason
• Will we get Visual Designs to work on ?
• Should we do multiple assignee ?

Will be updating this as soon as I get updates, then will create issues in respective repo.

[michaelkleinhenz]

@pranavgore09 yes to all my points above. On the multi-assignees: I think this would not exceed the story to allow more that one assignee added at once using a different UI control. I would expect that we build something that allows only one assignee right now, this will be throwaway code in the future. So I'd add the multi-assignees to this story, because the balance between "more work" and "not creating something that we need to tear down later" is tending to "do it right now".

[AdamJ]

@pranavgore09 the story and wireframes you have listed are correct. Currently, the designs do not support multiple assignees.

@michaelkleinhenz as multiple assignees is not required for 'what we need for the product to work', UXD did not include that in this iteration. Are the development efforts to do what is done per iteration, or extend to what may come down the line? As far as I know (correct me if I'm wrong, @Mgranfie), multiple-assignees are not within sight. My only hesitation with implementing outside of the current design is when it comes back to comparison of design vs product. Bugs / errors may be filed if it does not match.

[Mgranfie]

@ajolicoe We have not designed for multiple assignees, at this time. We
will address this at a later time, further down the line.

On Mon, Nov 7, 2016 at 9:27 AM, Adam Jolicoeur notifications@github.com
wrote:

@pranavgore09 https://github.com/pranavgore09 the story and wireframes
you have listed are correct. Currently, the designs do not support multiple
assignees.

@michaelkleinhenz https://github.com/michaelkleinhenz as multiple
assignees is not required for 'what we need for the product to work', UXD
did not include that in this iteration. Are the development efforts to do
what is done per iteration, or extend to what may come down the line? As
far as I know (correct me if I'm wrong, @Mgranfie
https://github.com/Mgranfie), multiple-assignees are not within sight.
My only hesitation with implementing outside of the current design is when
it comes back to comparison of design vs product. Bugs / errors may be
filed if it does not match.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#341 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARTwq7rGFoC5X7Cd1v7SzsyW1UWOXRUzks5q7zVhgaJpZM4KOxyj
.

[pranavgore09]

Correct @mindreeper2420 if dev team go ahead and sets up codebase to have multiple assignees, then bugs/errors will be raised which wont fit the model.
I have added a question for the same.
Thanks @Mgranfie

[michaelkleinhenz]

@mindreeper2420 @Mgranfie ok, then we leave it at one assignee per work item.

[AdamJ]

@michaelkleinhenz @pranavgore09 @Mgranfie @aslakknutsen Will emails be served to the UI from the backend? I want to make sure that the wireframes fit the correct model.

[aslakknutsen]

@mindreeper2420 I would say no.The backend could search on email, but not give them to the 'other users'. email normally require extra permissions.

[AdamJ]

@michaelkleinhenz @joshuawilson I've referenced a new UX story for updated wireframes, based off of the new, simplified, requirements. These do not include Search, Email display or invite via email.

[joshuawilson]

@mindreeper2420 Can you please add the reference to the new UX design to the main description of the this story.

[AdamJ]

@joshuawilson I cannot edit descriptions or add tags in almighty-core

[joshuawilson]

@mindreeper2420 can you add the link to a comment?

[AdamJ]

@joshuawilson Here is the Assign User UX work: fabric8-ui/fabric8-ux#53

[joshuawilson]

@mindreeper2420 so the design we implemented is closer to 40 then 53, only don't actually have email address to display. Everything else is there, including type ahead / filtering.

[michaelkleinhenz]

Done. Demoed in review.