Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images are not being published #444

Closed
hohonuuli opened this issue Oct 1, 2019 · 5 comments
Closed

Docker images are not being published #444

hohonuuli opened this issue Oct 1, 2019 · 5 comments
Labels

Comments

@hohonuuli
Copy link

It looks like there's a script, scripts/update-docker-images.sh in .travis.yml that's supposed to build and push a new image to dockerhub when a release is tagged. The current almond.sh release is 0.8.2, but the last tag on dockerhub is 0.6.0.

Because of this the instructions at https://almond.sh/docs/try-docker don't work.

@hohonuuli
Copy link
Author

Also, thanks for your work @alexarchambault!

@sbrunk sbrunk added the bug label Oct 2, 2019
@sbrunk
Copy link
Member

sbrunk commented Oct 2, 2019

Thanks @hohonuuli for catching this. the update-docker-images script is indeed failing in CI since 0.6.0

@sbrunk
Copy link
Member

sbrunk commented Oct 2, 2019

Seems like the docker daemon on travis ignores the ONBUILD directive causing it to fail when trying to copy a non-existing ivy-local directory.
Works fine locally with Docker 19.03.1

almond/Dockerfile

Lines 29 to 32 in a748d44

FROM coursier_base as local_ivy_yes
USER $NB_UID
ONBUILD RUN mkdir -p .ivy2/local/
ONBUILD COPY --chown=1000:100 ivy-local/ .ivy2/local/

@sbrunk
Copy link
Member

sbrunk commented Oct 5, 2019

@hohonuuli The Docker builds are fixed now and @alexarchambault has re-published images for the latest release:
https://hub.docker.com/r/almondsh/almond/tags

@hohonuuli
Copy link
Author

@sbrunk Thanks for fixing that. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants