Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Blocks don’t properly destroy themselves" #654

Closed
wimleers opened this issue Aug 7, 2012 · 7 comments
Closed

"Blocks don’t properly destroy themselves" #654

wimleers opened this issue Aug 7, 2012 · 7 comments

Comments

@wimleers
Copy link
Contributor

wimleers commented Aug 7, 2012

Was reported at the end of the Aloha + Spark sprint by the Aloha developers. I'm not sure if that's still the case, or what it implies exactly.

Just trying to make sure this has actually been solved.

Possibly related to #652.

@deliminator
Copy link
Contributor

I spoke with petro: the captioned image plugin has no implementation for makeClean(). Also, calling mahalo() should restore the editable so that all blocks are cleaned. I think both is not currently the case.

@deliminator
Copy link
Contributor

makeClean() is now implemented 6e23ddc

@wimleers
Copy link
Contributor Author

Hurray :)

I think this can be closed now?

@evo42 evo42 closed this as completed Aug 14, 2012
@deliminator
Copy link
Contributor

I fixed block related memory leaks.
cf9ed73
6d498cc
With that, everything works as it should as far as I can tell.

@wimleers
Copy link
Contributor Author

Cool, thanks for that — I didn't know about .free().

@deliminator
Copy link
Contributor

Well, there was no free to begin with until I added it :-).
The person implementing blocks obviously didn't put much thought into the editable lifecycle.

@wimleers
Copy link
Contributor Author

I think this (6e23ddc) fixed #652?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants