Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of download zip feature #3

Closed
2 tasks
winterrdog opened this issue May 14, 2022 · 3 comments
Closed
2 tasks

Implementation of download zip feature #3

winterrdog opened this issue May 14, 2022 · 3 comments

Comments

@winterrdog
Copy link
Contributor

winterrdog commented May 14, 2022

Hey @alok8bb,
How did you intend to implement the download zip feature?

  • My Case 1:
    Is the program supposed to download a zip archive that's already hosted on GitHub?

  • My Case 2:
    Is the program zip archiving the files to be downloaded on the fly?

How would you want it implemented?

Looking forward to your response! 🙂

@alok8bb
Copy link
Owner

alok8bb commented May 15, 2022

Hello @winterrdog

The tool is supposed to download the files/subdirectories from that URL to a temp directory in the system, zip it and move to work dir.
Or we can create a custom backend for zipping the files before downloading, that works as well.

I'm currently a little busy with my studies so I might not be able to contribute. If you want to, you can implement it in any way you like :)

@winterrdog
Copy link
Contributor Author

Hey @alok8bb, thanks for the response. I'll try to implement it since I've got some free time. Surely, I'll be sending in a PR soon with more changes for review🤝.

Great luck in your studies too👍

@alok8bb
Copy link
Owner

alok8bb commented May 15, 2022

Thanks 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants