Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseJsonFile - manual saving #130

Closed
martin-braun opened this issue Jan 12, 2022 · 1 comment
Closed

UseJsonFile - manual saving #130

martin-braun opened this issue Jan 12, 2022 · 1 comment

Comments

@martin-braun
Copy link

I just realized that this library will use the INotifyPropertyChange interface to trigger re-writting the JSON file, which is not what I want. What I need is a way to save and overwrite the file only when calling a method.

I tried to bypass this issue by using UseJsonConfig and using the methods of Newtonsoft to do the saving by myself, but this package will prevent me from modifying my config interface when I use UseJsonConfig, so I cannot bypass this without building my own class on which I map the values to.

So my conclusion is that there is no point in using this package anymore, because I'd end up with more work than just using the direct Newtonsoft-way, which is the price I have to pay in any case. Not the best situation, I should've checked everything way closer to make sure this is the right tool for my task. I'm creating this issue to suggest a manual save method when using UseJsonFile.

Thank you.

@aloneguid
Copy link
Owner

Agreed, if you just need json then overabstration is a wrong way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants