-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: JSON serializer doesn't produce valid json (table) #409
Comments
It's actually a feature :) It produces output in json-lines format, more commonly used in big data platforms like Apache Spark. Having one document with massive array does not allow for easy streaming of JSON. |
isn't that supposed to be the serialization of rows? when i serialize a table I would expect to have a representation of the table and not multiple rows. |
You can call |
that's what we did. basically we did it the same way like you did in the ToString() method but removed the limitation with the level filter. unfortunately that was just a workaround for deserializing parquet to c# classes. as the parquet deserializer had too many limitations we convert the parquet first to json and use the system.text.json deserializer to get our c# objects. |
The performance of this will be terrible :( What kind of limitations did you encounter with class serializer by the way? |
the most important issues we have are:
|
Fair enough, thanks. Regarding the first, it will change in future. I'm planning to unify code for row api and class serializer, which will make row api more stable, but also allow declaring properties of |
Library Version
4.16.4
OS
Windows 11
OS Architecture
64 bit
How to reproduce?
instead of this
we should get this
Failing test
The text was updated successfully, but these errors were encountered: