Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field name with dot (.) #82

Closed
felipepessoto opened this issue Sep 25, 2020 · 5 comments
Closed

Field name with dot (.) #82

felipepessoto opened this issue Sep 25, 2020 · 5 comments

Comments

@felipepessoto
Copy link
Contributor

This commit 16b55d5 added a validation to disallow fields with dots.

Do we really have a reason to don't accept dots? If I comment the throw line I can read a file with dots in column names, and the only failing test is the test that validates if it throws when we use dots.

I couldn't find any spec saying dots are not allowed.

Thanks.

@kirchsth
Copy link

A dot is the Schema.PathSeparator and used in e.g. paths of StructField's as separator if you store e.g. (list of) structs

@felipepessoto
Copy link
Contributor Author

The problem is, some viewer like ParquetFileViewer can't open the parquet files if column has a dot.

@felipepessoto
Copy link
Contributor Author

Any update? Is this by design? Is it possible to fix it, or have a opt-in option to allow dots?

@aloneguid
Copy link
Owner

Parquet spec does allow dots so Id say we should too.

@felipepessoto
Copy link
Contributor Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants