Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAPP ignores suggested changes in document #49

Open
hftf opened this issue Jan 31, 2024 · 2 comments
Open

YAPP ignores suggested changes in document #49

hftf opened this issue Jan 31, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@hftf
Copy link
Collaborator

hftf commented Jan 31, 2024

Documents may contain (intentionally or not) unaddressed suggested edits/tracked changes/revisions. In the WordprocessingML schema, suggested edits are represented primarily by the elements <w:ins> and <w:del>.

YAPP ignores these elements entirely, which means that both the original text (deletion) and suggested text (insertion) are missing from the output. This can result in missing substantive words, answerlines, etc. and a serious impact on gameplay.

Supporting suggested edits shouldn't be very involved: my first hunch is changing "r" to "r" or "ins" in the condition below.

IEnumerable<Run> runs = paragraph.ChildElements.Where(element => element.LocalName == "r").Cast<Run>();

@alopezlago
Copy link
Owner

I could look into this. Is this that common? I imagine reading tracked changes packets would be distracting.

@hftf
Copy link
Collaborator Author

hftf commented Mar 10, 2024

It occasionally happens that comments and suggestions are left unaddressed, since packets tend to be proofread in a late crunch and many editors with overlapping responsibilities and responsivities are involved in the operation. The point is that YAPP ignores everything – both the original and the suggestion – causing missing substantive text or answerlines, which is a severe issue, while in other software you at least have a choice of how to view tracked changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants