Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on material-icons-extended #17

Closed
darvld opened this issue Oct 30, 2021 · 3 comments · Fixed by #18
Closed

Remove dependency on material-icons-extended #17

darvld opened this issue Oct 30, 2021 · 3 comments · Fixed by #18

Comments

@darvld
Copy link
Contributor

darvld commented Oct 30, 2021

material-icons-extended is a significantly large library, and it should not be required as a dependency for this library, instead, the library users should choose which icons to use.
@alorma
Copy link
Owner

alorma commented Oct 31, 2021

Sure @darvld, could you make a PR removing it?

@darvld
Copy link
Contributor Author

darvld commented Oct 31, 2021

Will do, thanks!

@darvld darvld mentioned this issue Oct 31, 2021
Merged
@darvld
Copy link
Contributor Author

darvld commented Oct 31, 2021

@alorma Done, awaiting approval.

@alorma alorma closed this as completed in #18 Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Remove dependency on material-icons-extended.
2 participants
@alorma @darvld