Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack DataStore support #43

Closed
pelmenstar1 opened this issue Aug 20, 2022 · 4 comments
Closed

Jetpack DataStore support #43

pelmenstar1 opened this issue Aug 20, 2022 · 4 comments

Comments

@pelmenstar1
Copy link
Contributor

It would be great if the library had the explicit support of Jetpack DataStore. It's doable without the support of the library, but the output code is quite hard to support then.

@alorma What do you think about it?
@alorma
Copy link
Owner

alorma commented Aug 20, 2022

Hi @pelmenstar1

Sure, I've done some work on that way time ago. But never finished it.

Would you like to open a PR with that addition?

@pelmenstar1
Copy link
Contributor Author

I'm working on it right now.

@alorma
Copy link
Owner

alorma commented Aug 20, 2022

Great! Open a PR when you think it's done and I will review that.

Thank you!

@alorma
Copy link
Owner

alorma commented Aug 20, 2022

Hey @pelmenstar1 !

just updated to compose 1.2.1, so please rebase your WIP branch in order to get all changes:

https://github.com/alorma/Compose-Settings/releases/tag/0.9.0

@alorma alorma closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alorma @pelmenstar1