-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recompose problems #66
Comments
Hi! Can you provide a small project to reproduce the case? |
UtilityServices-1.zip |
I will check, thanks |
@alorma Thanks a lot. |
Hi! The project is cool, but it doesn't contains compose-settings on it 😅 |
I mean.. on the zip you provided, at least on the "develop" branch, I've removed the git and keystores files as I don't want that info |
BTW, there are few things I see... Maybe
shouldn't belong to the settings composable, instead try to pass it through params, so it has to change whenever theme change |
oh, I see it now.. on git. checking |
@alorma I tried check guides and bla bla, so I saw no state values as properties, only plain objects |
Well... I get the problem, but not understand why it's happening... |
I have a temporal solution... while I investigate more Instead of SettingsSwitch(
title = { Text(text = stringResource(R.string.dark_mode)) } // declare `stringResource` here
) Use val darkModeText = stringResource(R.string.dark_mode) // declare `stringResource` here, OUTSIDE of settings
SettingsSwitch(
title = { Text(text = darkModeText) },
) That sloves the problem... not sure why recomposition is not happening there... but at least problem is mitigated |
@alorma magic, I will test, thanks a lot. Magic, but it works |
@alorma
Hm, can not recompose switchers Material 3 component when changed language
Looks like https://prnt.sc/GG-Owt-VbALQ
I mean recompose does not work for your switchers when changed configuration (locale).
Please try check, thanks a lot.
The text was updated successfully, but these errors were encountered: