Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust position of plots for Attack seq #4

Closed
alosdiallo opened this issue Feb 5, 2019 · 11 comments
Closed

Adjust position of plots for Attack seq #4

alosdiallo opened this issue Feb 5, 2019 · 11 comments

Comments

@alosdiallo
Copy link
Owner

Adjust the positions of the plots so that you don't have to scroll to view them.

@KHBHH
Copy link
Collaborator

KHBHH commented Feb 18, 2019

I am working on this, using the CSS trick.

@alosdiallo
Copy link
Owner Author

No problem

@KHBHH
Copy link
Collaborator

KHBHH commented Feb 20, 2019

I tried to adjust the size of plots using the CSS trick, so that they will fit in one panel (I have inlcuded the UI in html file), you can test it here:
https://hmsimmunodept.shinyapps.io/DNARchitect_qa/

Now, The buttons show beside each other above the plots whenever I select more than a plot, for instance(HiC-ATAC).
Before, I had the download button under each plot. What do you think?

@KHBHH
Copy link
Collaborator

KHBHH commented Feb 20, 2019

I will make the fontsize of texts on the plot bigger (I will inlcude it later)

@KHBHH
Copy link
Collaborator

KHBHH commented Mar 5, 2019

This is done, but still need to deploy it to shinyapps.io to make sure it works there, will let you know till tomorrow!

@KHBHH
Copy link
Collaborator

KHBHH commented Mar 5, 2019

I deployed it to shinyapps.io, you can check it here. https://hmsimmunodept.shinyapps.io/DNARchitect_qa/

I changed the size of the plots (they look a little bit smaller now) and if more than 1 data is chosen, they should show beneath each other without so much space between them.

Right now I just need to check if this looks fine in smaller screens, as my PC has a bigger one. Please let me know what you think.

@KHBHH
Copy link
Collaborator

KHBHH commented Mar 5, 2019

I can change the sizes of the plots if they look small.

@KHBHH
Copy link
Collaborator

KHBHH commented Mar 17, 2019

I fixed the 'croping genome names' problem, but I need to test it on smaller screen to make sure it is working. Mine is pretty large.

@KHBHH
Copy link
Collaborator

KHBHH commented Apr 3, 2019

Regarding this, I tried to play around with the css trick, but it seems that the extra space in the plot is from the plot itself, and it makes sense. With hic_bedpe file the genes underneath the plot are few, that's why we notice the white space. But when I did plot K562_NHEK_GM12878-loops.txt the genes filled the space. Maybe it is better to discuss this live.

hic_bedpe

(the file attached below does not show bezier curves, that is another issue that I will check with Ricardo, I just put it so that the genes are shown)

hg19-pax5

@KHBHH
Copy link
Collaborator

KHBHH commented Apr 11, 2019

I think this is done, we can discuss it after you check.

@alosdiallo
Copy link
Owner Author

Resolving to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants