Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker API: Trading - Trading Account Configuration #34

Closed
drew887 opened this issue May 5, 2022 · 0 comments · Fixed by #60
Closed

Broker API: Trading - Trading Account Configuration #34

drew887 opened this issue May 5, 2022 · 0 comments · Fixed by #60
Assignees
Labels
Broker API Relates to the Broker API enhancement New feature or request

Comments

@drew887
Copy link
Contributor

drew887 commented May 5, 2022

Implement the routes from the docs here

Also missing from the docs is a GET route for /v1/trading/accounts/{account_id}/account/configurations that we should implement here

Should add the following interface to BrokerClient:

  def get_trade_configuration_for_account(
          self,
          account_id: Union[UUID, str]
  ): -> TradeAccountConfiguration:
      pass

  def update_trade_configuration_for_account(
          self,
          account_id: Union[UUID, str],
          config: UpdateTradeConfigurationRequest
  )-> TradeAccountConfiguration:
      pass
@drew887 drew887 added enhancement New feature or request Broker API Relates to the Broker API labels May 5, 2022
@drew887 drew887 added this to To do in General Development via automation May 5, 2022
@drew887 drew887 added this to the Broker API Alpha Release milestone May 5, 2022
@drew887 drew887 self-assigned this May 9, 2022
@drew887 drew887 moved this from To do to In progress in General Development May 9, 2022
@drew887 drew887 moved this from In progress to Review in progress in General Development May 13, 2022
General Development automation moved this from Review in progress to Done May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Broker API Relates to the Broker API enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant