Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPercentChanges calls the get_barset for minute length? but the comment says for day length #127

Closed
aleel1597 opened this issue Dec 10, 2019 · 2 comments

Comments

@aleel1597
Copy link

I was wondering why the getPercentChanges calls bars = self.alpaca.get_barset(stock[0], 'minute', length) on line 312 for the 'minute' as the second argument when the comment says it wants the percent change over past 10 days?

@aleel1597
Copy link
Author

this was for the example code in long-short.py

@ttt733
Copy link
Contributor

ttt733 commented Jan 29, 2020

The comment in the example has been updated, thank you for pointing it out.

@ttt733 ttt733 closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants