Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify accelerator names in CMake #1124

Open
bernhardmgruber opened this issue Aug 18, 2020 · 3 comments
Open

Simplify accelerator names in CMake #1124

bernhardmgruber opened this issue Aug 18, 2020 · 3 comments
Labels
Type:CMake Related to build system Type:Enhancement

Comments

@bernhardmgruber
Copy link
Member

To enable/disable accelerators in CMake, there are various options, like:

ALPAKA_ACC_CPU_BT_OMP4_ENABLE
ALPAKA_ACC_CPU_B_OMP2_T_SEQ_ENABLE
ALPAKA_ACC_GPU_CUDA_ENABLE

These names are sometimes confusing (like why is there a B and a T in the name). Furthermore, they do not correspond to the names we use in code. E.g. ALPAKA_ACC_CPU_B_SEQ_T_SEQ_ENABLE corresponds to alpaka::acc::AccCpuSerial in code.

I would like to propose to rename the options in CMake to match the accelerator names in code:

ALPAKA_ENABLE_AccCpuSerial
ALPAKA_ENABLE_AccCpuOmp2Blocks
ALPAKA_ENABLE_AccGpuCudaRt
@bernhardmgruber
Copy link
Member Author

bernhardmgruber commented Mar 22, 2023

I was about to open an issue about this now and then thought that maybe someone already proposed this. Well, it was me :)

I would like us to revisit this again. It's just to hard (for me) to remember how to spell all the cmake variables on the command line.

We may even go shorter:

alpaka_ENABLE_CUDA
alpaka_ENABLE_SERIAL
alpaka_ENABLE_OMP2_BLOCK
alpaka_ENABLE_OMP2_THREADS

etc.

@bernhardmgruber bernhardmgruber added this to To do in Release 1.0 via automation Aug 7, 2023
@bernhardmgruber
Copy link
Member Author

I would like to discuss about the fate of this issue before we release alpaka 1.0, since it breaks a user's cmake use.

@j-stephan j-stephan added Type:CMake Related to build system and removed Type:Install installation & packaging labels Aug 16, 2023
@bernhardmgruber bernhardmgruber removed this from To do in Release 1.0 Aug 29, 2023
@bernhardmgruber
Copy link
Member Author

We discussed that this should go together with #1019 sometime in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:CMake Related to build system Type:Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants