Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: support add_subdirectory #10

Open
ax3l opened this issue Oct 19, 2018 · 2 comments
Open

CMake: support add_subdirectory #10

ax3l opened this issue Oct 19, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ax3l
Copy link
Member

ax3l commented Oct 19, 2018

The CMakeLists.txt need a little update to allow adding LLAMA as in-source dependency via add_subdirectory().
@ax3l ax3l added the enhancement New feature or request label Oct 19, 2018
@ax3l ax3l mentioned this issue Oct 21, 2018
Closed
@bernhardmgruber
Copy link
Member

We brought this up in the alpaka VC just now and @psychocoderHPC explained to me why add_subdirectory() is a valid way of including a library dependency. I think we should make sure we support this.

@bernhardmgruber bernhardmgruber changed the title CMake: Modernize CMake: support add_subdirectory Sep 15, 2021
@bernhardmgruber bernhardmgruber mentioned this issue Sep 15, 2021
Closed
@bernhardmgruber bernhardmgruber added the help wanted Extra attention is needed label Sep 15, 2021
@bernhardmgruber
Copy link
Member

Even though we don't have a test for it, I know it works, because I use add_subdirectory for LLAMA within other projects, like PIConGPU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bernhardmgruber @ax3l