Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prolonged click on suggestion issue #347

Closed
d-lan1 opened this issue Jul 1, 2019 · 2 comments
Closed

Prolonged click on suggestion issue #347

d-lan1 opened this issue Jul 1, 2019 · 2 comments

Comments

@d-lan1
Copy link

d-lan1 commented Jul 1, 2019

When clicking(mousedown) on the autocomplete recommendations for slightly longer than usual, the drop down disappears and no item is selected. I would expect the dropdown to remain open until the click is released OR as soon as the mousedown event has fired for the item to be selected.

Could somebody code review, test and merge this pull request in please?
#342

NOTE: In this pull request I have fixed the above issue. In addition to this I have also removed the quotation marks from the npm scripts as this was causing issues with execution on my windows machine.

@d-lan1
Copy link
Author

d-lan1 commented Jul 15, 2019

@aliuk2012 @alphagov Can someone please review/merge in this pull request please?

@NickColley
Copy link
Contributor

Closing this as a duplicate of #328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants