Make S3 bucket public in integration

[chrisroos]

We'll need to do this in order to serve assets directly from S3.

[floehopper]

I think this is simply a matter of changing the acl argument on the bucket from "private" to "public-read". See the documentation for Terraform's aws_s3_bucket resource and S3 canned ACLs.

[floehopper]

See alphagov/govuk-terraform-provisioning#128.

[chrisroos]

We've made and merged the necessary change in alphagov/govuk-terraform-provisioning#130. We're currently waiting for this change to be deployed to integration.

[chrisroos]

The changes in alphagov/govuk-terraform-provisioning#130 have now been deployed to integration.

I've tested that the change is working as expected by uploading an attachment to a Manual Section (in Manuals Publisher) and requesting the uploaded asset with the redirect_to_s3=true querystring.

[floehopper]

Based on @chrisroos' last comment, I'm closing this issue. @chrisroos: Please re-open if you think we've missed anything.